fix(cluster): skip pruning servers without provider server id #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NathanFlurry and the rest of your teammates on |
NathanFlurry
force-pushed
the
09-05-fix_job-run_fix_dupe_allocs_re-enable_drain_all
branch
from
ded4a90 to
5a66f5a
Compare
NathanFlurry
force-pushed
the
09-06-fix_cluster_skip_pruning_servers_without_provider_server_id
branch
from
c60c307 to
b8c5306
Compare
This was referenced Sep 10, 2024
MasterPtato
approved these changes
Sep 13, 2024
| for server in servers { | ||
| let linode_id = unwrap_ref!(server.provider_server_id).parse()?; | ||
| let Some(linode_id) = &server.provider_server_id else { | ||
| tracing::warn!(server_id = ?server.server_id, "provider_server_ide is none"); |
Contributor
There was a problem hiding this comment.
Suggested change
| tracing::warn!(server_id = ?server.server_id, "provider_server_ide is none"); | |
| tracing::warn!(server_id = ?server.server_id, "server has no provider_server_id"); |
MasterPtato
force-pushed
the
09-05-fix_job-run_fix_dupe_allocs_re-enable_drain_all
branch
from
5a66f5a to
3d69a7b
Compare
MasterPtato
force-pushed
the
09-06-fix_cluster_skip_pruning_servers_without_provider_server_id
branch
from
b8c5306 to
82d15b7
Compare
Contributor
Merge activity
|
NathanFlurry
added a commit
that referenced
this pull request
Sep 28, 2024
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
09-06-fix_cluster_skip_pruning_servers_without_provider_server_id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes